Skip to content

Adds LilyGo T Relay S3 board definition #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adds LilyGo T Relay S3 board definition #9449

wants to merge 2 commits into from

Conversation

LordRafa
Copy link

@LordRafa LordRafa commented Apr 2, 2024

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Description of Change

Add LilyGo T Relay S3 board definition

Tests scenarios

Tested compilation against basic examples.

Related links

Pins documentation is wrong. I check pins avaiale directly on the schematic

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Rafael Waldo Delgado Doblas
❌ LordRafa

Rafael Waldo Delgado Doblas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Adds LilyGo T Relay S3 board definition":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️

The source branch "7b29bac+LilyGo_T_Relay_S3_board_definition" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello LordRafa, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2b6249b

@lucasssvaz lucasssvaz added Type: 3rd party Boards Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Apr 3, 2024
@P-R-O-C-H-Y
Copy link
Member

@LordRafa can you please sign CLA?

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LordRafa PTAL

variants/lilygo_t_relay_s3/pins_arduino.h
Comment on lines +10 to +16
#define EXTERNAL_NUM_INTERRUPTS 46
#define NUM_DIGITAL_PINS 48
#define NUM_ANALOG_INPUTS 20

#define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1)
#define digitalPinToInterrupt(p) (((p)<48)?(p):-1)
#define digitalPinHasPWM(p) (p < 46)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part have been moved and its defined globally per SoC. Please remove it.

Suggested change
#define EXTERNAL_NUM_INTERRUPTS 46
#define NUM_DIGITAL_PINS 48
#define NUM_ANALOG_INPUTS 20
#define analogInputToDigitalPin(p) (((p)<20)?(analogChannelToDigitalPin(p)):-1)
#define digitalPinToInterrupt(p) (((p)<48)?(p):-1)
#define digitalPinHasPWM(p) (p < 46)

lucasssvaz
lucasssvaz requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also recommit your changes using only your Github username otherwise the CLA won't be able to be properly signed

@me-no-dev
Copy link
Member

Closing for lack of response. We can not merge PRs without signed CLA. @LordRafa feel free to open a new PR if you are willing to sign the CLA

@me-no-dev me-no-dev closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz requested changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y requested changes

Assignees
No one assigned
Labels
Status: Pending CLA ⚠️ Contributor is required to sign the CLA Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LordRafa @CLAassistant @P-R-O-C-H-Y @me-no-dev @lucasssvaz